Skip to content

Feat/web input - #768

Merged
TorinAsakura merged 38 commits into
feat/v2from
feat/web-input
Sep 9, 2026
Merged

Feat/web input#768
TorinAsakura merged 38 commits into
feat/v2from
feat/web-input

Conversation

@comfrt1k

@comfrt1k comfrt1k commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

Таска

Как проверять

  1. Контекст: Storybook → Components/Input → Variants
    Действие: переключить appearance, shape и theme; проверить focus, error, disabled, helper text, leading addon и trailing addon
    Ожидаемый результат: обе темы, все appearances и shapes отображаются корректно; при focus размер поля не меняется; error и focus различимы одновременно; сообщения читаемы; disabled-поле недоступно для ввода; addons выровнены относительно текста

  2. Контекст: Storybook → Components/Input → Search, Clearable, Password, Phone, Email
    Действие: ввести и очистить значения мышью и клавиатурой, переключить видимость пароля, проверить валидные и невалидные телефон и email
    Ожидаемый результат: typed inputs сохраняют состояния Input; Clearable после Enter и Space возвращает focus в поле; Password переключает видимость значения; невалидные телефон и email показывают ошибку, валидные — снимают её

  3. Контекст: Storybook → Components/Textarea → Variants
    Действие: переключить appearance, shape, theme, rows, error, helper text и disabled; установить focus и ввести многострочный текст
    Ожидаемый результат: Textarea поддерживает те же визуальные состояния, что и Input; при focus размер не меняется; error и focus различимы одновременно; rows изменяет высоту; disabled-состояние блокирует ввод

  4. Контекст: Storybook Accessibility для Input, typed inputs и Textarea
    Действие: запустить accessibility-проверку каждой story и пройти элементы клавишей Tab
    Ожидаемый результат: все поля имеют доступное имя; focus виден на input и action-кнопках; отсутствуют ошибки контраста и потеря focus

Пруфы

Details
2026-08-31.23.53.04.mov
2026-08-31.23.55.16.mov
2026-08-31.23.53.45.mov

Base automatically changed from feat/web-button to master August 31, 2026 17:42
@comfrt1k
comfrt1k marked this pull request as ready for review August 31, 2026 20:56
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T14:11:21.268840Z a936da1 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb0bd00c89

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ui-parts/input/src/typed/clearable/component.tsx Outdated
@comfrt1k
comfrt1k requested a review from TorinAsakura August 31, 2026 21:45

@TorinAsakura TorinAsakura left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В PR не заполнено, как проверять реализацию, и не приложен визуальный пруф. Зелёные проверки подтверждают сборку, типы и тесты, но не позволяют проверить соответствие Figma и заявленные интерактивные состояния.

Нужно указать точный Storybook-сценарий и приложить скринкаст или набор скриншотов, на которых проверены обе темы, размеры и основные состояния: focus, error, disabled, helper/error messages, addons, typed inputs и Textarea.

Comment thread ui-parts/input/src/index.ts
Comment thread ui-parts/input/src/component.tsx
Comment thread ui-parts/input/src/typed/shared/use-string-value.ts
Comment thread ui-parts/input/src/styles/appearance/styles.css.ts
Comment thread ui-parts/input/src/action/styles.css.ts
Comment thread ui-parts/input/src/typed/clearable/component.tsx
Comment thread ui-parts/input/src/component.tsx Outdated
Comment thread ui-parts/input/src/styles/appearance/variants.ts
Comment thread ui-parts/input/stories/component.stories.tsx

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ad8b88fc21

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ui-parts/input/src/typed/shared/use-string-value.ts Outdated
Comment thread ui-parts/input/src/typed/clearable/component.tsx Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 3b804db133

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ui-parts/input/src/typed/shared/use-string-value.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 65ebcaaa45

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ui-parts/input/src/typed/shared/use-string-value.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: dc83f4107d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ui-parts/autocomplete/src/autocomplete.component.tsx
@comfrt1k

comfrt1k commented Sep 3, 2026

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b27d399980

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ui-parts/input/src/typed/clearable/interfaces.ts Outdated
Comment thread ui-parts/input/src/component.tsx

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8811ec7361

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ui-parts/input/src/typed/shared/use-string-value.ts

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 890db35959

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ui-parts/input/src/component.tsx
Comment thread ui-parts/input/src/styles/layout/container.css.ts
BREAKING CHANGE: Input type now accepts only text-field variants and hidden.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a936da11c2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ui-parts/input/src/textarea/component.tsx
@TorinAsakura
TorinAsakura merged commit 33a1282 into feat/v2 Sep 9, 2026
6 checks passed
@TorinAsakura
TorinAsakura deleted the feat/web-input branch September 9, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Реализовать Input для Hyperion Web

2 participants