Repository navigation
Release 0.4.0 - #102
Merged
Merged
Release 0.4.0#102
Conversation
- DESCRIPTION version 0.4.0 - NEWS.md rewritten for the release: the partial entry covered only the four PRs that landed before the JSON rewrite, and said nothing about the precision fix, the new NDJSON and DSJC formats, the dropped dependencies, or the deprecations - cran-comments.md records the two things CRAN will look at here: the bundled yyjson library and where its MIT attribution lives, and the zlib link that the compressed format needs - Fixed a moved URL in the README, and three real misspellings the spell check found (defintions, leiu, and Behaviour against the declared Language: en-US). Technical terms added to inst/WORDLIST
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release preparation for 0.4.0 — the housekeeping we deferred out of the feature PRs.
What's here
DESCRIPTION— version0.4.0NEWS.md— rewritten. The existing 0.4.0 section only covered the four PRs that landed before the JSON rewrite (Documentation: converting_files.Rmd update #71, coercion of "NA" for numeric variables on read #76, Feature Request: Default decimal_as_float = TRUE #77, preserve format.sas #87) and said nothing about the precision fix, the two new formats, the dropped dependencies or the deprecations. It is now organised by what a user needs to know: what changed under the hood, what is new, what behaves differently, and what was fixed.cran-comments.md— records the two things CRAN will look at here: the bundledyyjsonlibrary and where its MIT attribution lives, and thezliblink the compressed format needs.Incidental fixes the release checks turned up
swhume.github.io→humedatalabs.com)defintions,leiu, andBehaviour— the last against the package's ownLanguage: en-US. Technical terms added toinst/WORDLIST, which had not been touched since the template.Checks run
R CMD check --as-cranurlcheckerspellingStill to do before submitting
v0.4.0after mergedevtools::submit_cran()Worth a second opinion
This is the first release with compiled code, so the submission carries more surface than usual: a bundled third-party library, a system library link, and a
src/directory that has never been through CRAN's incoming checks. The vendoredyyjson.c/yyjson.hare byte-identical to upstream 0.12.0 and attribution is in three places (Authors@Rcph, DESCRIPTIONCopyright,inst/COPYRIGHTSwith the full MIT text), but a reviewer's eye on that would be welcome.