Repository navigation
Fix the pkgdown build - #103
Merged
Merged
Conversation
The reference index did not list datasetjson_example(), which pkgdown treats as an error rather than a warning, so the site build failed on the 0.4.0 merge. It is now under Helper Functions alongside the other two. Also cleared the two warnings the same build reported: - date_time_datetime and precision declared \VignetteIndexEntry values that did not match their titles, so the vignette index listed them by filename rather than as "Dates, Times, and Datetimes" and "Numeric Precision" - the codecov and licence badges in README.Rmd were raw <img> tags with no alt text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pkgdown workflow failed on the 0.4.0 merge (run):
datasetjson_example()was exported by #90 but never added to the reference index. pkgdown treats a missing topic as an error, not a warning, so the whole site build stops there. Checked the other 22 exports at the same time — it was the only one missing.Also cleared the two warnings the same build reported:
date_time_datetimeandprecisiondeclared\VignetteIndexEntryvalues that did not match their YAML titles, so the vignette index listed them by filename instead of "Dates, Times, and Datetimes" and "Numeric Precision"<img>tags with no alt textpkgdown::check_pkgdown()reports no problems, a full localbuild_site()completes with nothing under "Checking for problems", andR CMD check --as-cranis still 0/0/0.None of this affects the package source, so the 0.4.0 tarball already with CRAN is unaffected.