Repository navigation
test: tear down the verb test store after each test in three files - #2925
Merged
Merged
Conversation
abstract_verb_handler_test, stats_notification_test and the last group of monitor_verb_test call verbTestsSetUp but never verbTestsTearDown, so each leaves its Hive store behind in unit_test_storage. Every file using verbTestsSetUp opens that same directory, so the next one to run starts on the left-over records. When abstract_verb_handler_test ran just before scan_commit_log_test, the scan test's first test also counted the four enrollment records left behind, and saw 6 commit-log entries where it expects 2. Each now calls verbTestsTearDown after its tests, so none leaves the store behind for the next file.
cpswan
approved these changes
Nov 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
- Why
abstract_verb_handler_test,stats_notification_testand the last group ofmonitor_verb_testcallverbTestsSetUpbut neververbTestsTearDown, so they leave the Hive store inunit_test_storagebehind, and the next file to open it starts on those records.unit_tests (stable)failed that way, withscan_commit_log_testrunning straight afterabstract_verb_handler_testand counting 6 commit-log entries where it expects 2: https://github.com/atsign-foundation/at_server/actions/runs/41941825122/job/126964275664- How I did it
See commits
- How to verify it
Tests pass, including
scan_commit_log_testrun straight afterabstract_verb_handler_test, which was red before this change