Flxcld 2859 management server async job issue - #16
Open
db3922 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is a fix to use FQDN for msid with in a stable and integral way when running in a Kubernetes cluster. Current code creates a new msid for every mac address the server is started with. When restarting the management server this new msid leaves orphaned jobs behind.
Types of changes
Bug Severity
How Has This Been Tested?
Tested by running the management server in a Kubernetes cluster using statefulsets. After the change is applied when restarting the management server the ID is identical and allows proper clean up of jobs, and other task.
How did you try to break this feature and the system with this change?
Running CloudStack management server in Kubernetes and reviewing the cloud.mshost, cloud.mshost_peer table reveals the issue when orphaned entries.