fix(core): skip minimum gas consumption for simulated calls

[JonathanOppenheimer]

Why this should be merged

This was reported in ava-labs/avalanchego#5850.

ACP-194 charges real transactions:

chargedGas
  = limit - min(limit - actualGasUsed, limit - minimumConsumption)
  = max(actualGasUsed, minimumConsumption)
  = max(actualGasUsed, ceil(limit / 2))

During eth_estimateGas, this floor makes UsedGas depend on the trial gas limit. The geth estimator assumes UsedGas is a lower bound on the gas required for execution, so it can return an estimate near half of the sender's balance-derived gas allowance. This is incorrect, as we should not alter the behavior of RPCs as described in the issue report.

• Estimator caps the initial limit using balance and fee cap
• Estimator treats UsedGas as its lower bound
• Minimum consumption modifies UsedGas after refunds
• ACP-194 computes ceil(gasLimit / 2)

How this works

Adds a StateTransitionOption that explicitly disables minimum gas consumption for a state transition.

How this was tested

All existing UTs pass and I added a minimum-consumption unit test.

[JonathanOppenheimer]

pending discussion of better solution

[alarso16]

Aren't there other RPCs that need changed? Namely, the tracers?

[JonathanOppenheimer]

Aren't there other RPCs that need changed? Namely, the tracers?

Yeah the other 'simulated' (tracers, access-list) will also need to opt out -- I was thinking this PR provides the option/mechanism to do so, and then when I open the avalanchego bump PR, I can apply it at the appropriate call sites.

Does that sound reasonable to you?

[ARR4N]

Aren't there other RPCs that need changed? Namely, the tracers?

Yeah the other 'simulated' (tracers, access-list) will also need to opt out -- I was thinking this PR provides the option/mechanism to do so, and then when I open the avalanchego bump PR, I can apply it at the appropriate call sites.

Does that sound reasonable to you?

I don't think either of these should opt out. Tracers are meant to mirror the actual execution, and access-list-generation is orthogonal to the amount of gas consumed.

[JonathanOppenheimer]

Aren't there other RPCs that need changed? Namely, the tracers?

Yeah the other 'simulated' (tracers, access-list) will also need to opt out -- I was thinking this PR provides the option/mechanism to do so, and then when I open the avalanchego bump PR, I can apply it at the appropriate call sites.
Does that sound reasonable to you?

I don't think either of these should opt out. Tracers are meant to mirror the actual execution, and access-list-generation is orthogonal to the amount of gas consumed.

Hm I was just thinking of this through the gasUsed framing -- I will merge this as is (I applied your changes), and make a PR in AvalancheGo to bump libevm.