docs(webkit): fix second-level navigation and the first-level list in webkit-navigation - #894
Open
gabriel-lisboa-azion wants to merge 1 commit into
Open
docs(webkit): fix second-level navigation and the first-level list in webkit-navigation#894gabriel-lisboa-azion wants to merge 1 commit into
gabriel-lisboa-azion wants to merge 1 commit into
Conversation
… webkit-navigation A first-level module list is already named by the header breadcrumb, so it drops its PageHeading and opens on a controls row (narrowing left, the module's actions right) over the flush borderless table. Adds the rule that decides where a page's primary button lives — the tab row at size medium on a tabbed page, the controls row at size large on an untabbed one — with the height reservation that keeps a tab switch from nudging the page, and a breadcrumb table covering every level plus the rule that a tab is never a crumb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PageHeading— the breadcrumb crumb already names the module, so an<h1>repeating it only pushed the first table row below the fold. The page opens on a controls row instead: narrowing left, the module's actions right, over the flush borderlessCardBoxtable. Controls move out of the table's#toolbar(they belong to the page, not the table), which means search becomes a plainInputTextbound tov-model:globalFilter.size="medium",items-center, height reserved withmin-h-8so a tab switch never nudges the page); no tabs → the controls row (size="large"). Never both.?tab=), and that a tabbed page renders noPageHeading.How to test
node packages/webkit/scripts/check-authoring-docs.mjs→0 new(frontmatter + no file-as-example).npx prettier --check packages/webkit/cli-templates/claude/skills/webkit-navigation/SKILL.md→ passes./webkit-navigation <file>against a console list page and a tabbed detail page: it now flags aPageHeadingon a first-level list, a create button duplicated inside a tab, and a tab that changes the breadcrumb.Notes
webkit-navigationwas already in the bundle.