Skip to content

ci: run the toolkit job when a skill or agent doc changes - #898

Open
gabriel-lisboa-azion wants to merge 1 commit into
mainfrom
ci/toolkit-filter-skill-agent-docs
Open

ci: run the toolkit job when a skill or agent doc changes#898
gabriel-lisboa-azion wants to merge 1 commit into
mainfrom
ci/toolkit-filter-skill-agent-docs

Conversation

@gabriel-lisboa-azion

Copy link
Copy Markdown
Collaborator

Summary

  • The toolkit job runs the doc-standards ratchet (check-authoring-docs.mjs), the only CI gate for .claude/skills/** and .claude/agents/** — but neither path was in the job's change filter, so a skill- or agent-only PR skipped it. The gate was skipping exactly the PRs it exists to check (seen on docs: rewrite add-animation for the CSS-first theme #897, which changes one SKILL.md and ran nothing but CodeQL).
  • Adds both globs to the toolkit filter. governance.yml is the only workflow that runs this ratchet, so nothing else covered the gap; consumer skills under packages/webkit/cli-templates/claude/ were already covered by packages/webkit/**.
  • Until now authoring-docs.md's claim that the ratchet "fails on any introduced key even from an editor that never ran the hook" held only for the write-time hook on these two populations.

How to test

  1. On a branch off this one, edit any .claude/skills/*/SKILL.md (or .claude/agents/*.md) and nothing else, then open a PR. Expected: Detect Changes sets toolkit=true and Adoption Toolkit (tests + catalog drift) runs instead of reporting skipping.
  2. In that job, confirm the Skill/agent doc standards ratchet step executes. Locally the equivalent is pnpm --filter @aziontech/webkit run doc-standards — currently ✓ doc-standards ratchet: 7 known violations, 0 new.
  3. Break the doc deliberately (drop its scope: or enforced_by:) and push. Expected: the step fails with the new violation key, where before the whole job was skipped.

Notes

  • No release (ci).
  • Does not change the ratchet or its baseline — only which PRs trigger it. Previously-merged skill/agent PRs were never checked in CI, so the first PR to touch a given doc may surface pre-existing violations that are not in doc-standards-baseline.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants