Skip to content

fix(webkit): stop wrapped toast titles overlapping and pin the glyph to line one #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabriel-lisboa-azion wants to merge 1 commit into
base: fix/toast-item-alignment
Choose a base branch
from
Open

fix(webkit): stop wrapped toast titles overlapping and pin the glyph to line one #900

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions packages/webkit/src/components/feedback/toast/toast-item/toast-item.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,20 +56,25 @@
:role="role"
:data-testid="testId"
:data-type="type"
class="group pointer-events-auto relative flex w-full items-center gap-(--spacing-sm) rounded-(--shape-elements) border-solid border-[length:var(--border-width-default,1px)] border-(--border-default) bg-(--bg-surface-raised) p-(--spacing-sm) text-(--text-default) shadow-(--shadow-sm)"
class="group pointer-events-auto relative flex w-full items-start gap-(--spacing-sm) rounded-(--shape-elements) border-solid border-[length:var(--border-width-default,1px)] border-(--border-default) bg-(--bg-surface-raised) p-(--spacing-sm) text-(--text-default) shadow-(--shadow-sm)"
>
<div class="flex min-w-0 flex-1 items-start gap-(--spacing-sm)">
<Spinner
v-if="type === 'loading'"
class="size-4 shrink-0 self-center text-(--text-muted)"
/>
<i
v-else-if="icon"
:class="icon"
:data-type="type"
class="shrink-0 text-label-md leading-none text-(--text-muted) data-[type=success]:text-(--success-contrast) data-[type=info]:text-(--info-contrast) data-[type=warning]:text-(--warning-contrast) data-[type=error]:text-(--danger-contrast)"
<span
v-if="type === 'loading' || icon"
class="flex h-[1lh] shrink-0 items-center text-label-md"
aria-hidden="true"
/>
>
<Spinner
v-if="type === 'loading'"
class="size-4 text-(--text-muted)"
/>
<i
v-else
:class="icon"
:data-type="type"
class="leading-none text-(--text-muted) data-[type=success]:text-(--success-contrast) data-[type=info]:text-(--info-contrast) data-[type=warning]:text-(--warning-contrast) data-[type=error]:text-(--danger-contrast)"
/>
</span>
<div class="flex min-w-0 flex-1 flex-col gap-(--spacing-xxs)">
<slot />
</div>
Expand Down
2 changes: 1 addition & 1 deletion packages/webkit/src/components/feedback/toast/toast-title/toast-title.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
<p
v-bind="$attrs"
:data-testid="testId"
class="text-label-md leading-none text-(--text-default)"
class="text-label-md text-(--text-default)"
>
<slot />
</p>
Expand Down