Repository navigation
Popup announcements with required confirmation - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Admins can now show an announcement as a Banner (the default, same as today) or as a Popup with confirmation required. A popup blocks the page until the user clicks "I've read this". It has no X button and does not close on Esc or a click outside. Once a user confirms a popup, they don't see it again.
displaycolumn (migration stub, defaultbanner, so existing announcements stay banners) and a string-backedAnnouncementDisplayenum (Banner,Popup). A save guard keeps announcements that only target login or registration pages from being saved as popups.BODY_ENDthrough a newAnnouncementPopupsLivewire component. If several popups apply, they are shown oldest first with an "N of M" counter. Long popups scroll. The CSS uses a package prefix.SimplePagescopes) show the announcement as a normal banner. Guests never see popups, because they can't confirm them.announcement_dismissals), so the existing Reset dismissals action works without changes and makes everyone confirm again.Why
Users easily overlook banners or dismiss them without reading them. For important announcements, such as updated terms of service, admins need to know that every user has actually seen them. The full reasoning, decisions and anti-goals are in the spec.
docs/superpowers/specs/2026-10-27-popup-announcements-design.mddocs/superpowers/plans/2026-10-27-popup-announcements.mdAll 6 plan tasks are implemented, plus the fixes from the final review.
Screenshots
Demo
Chapters:
How it was tested
vendor/bin/pest --no-coverage: 39 passed (125 assertions)vendor/bin/pint --test: passcomposer analyse: exits 1, as it already did on the base commit 718e486. The 14 errors there predate this branch and come from duplicate larastan/carbon includes inphpstan.neon.dist. The PHPStan findings that this branch introduced are fixed.