Upgrade to mizer 3.4 - #5
Open
gustavdelius wants to merge 3 commits into
Open
Conversation
Merge from upstream
- Require mizer >= 3.4.0 in DESCRIPTION and add lifecycle to Imports - Register extension using recordExtension() in evoParams() and addSpecies() - Use S3 accessors and classes (MizerParams and MizerSim) - Rename deprecated evoParams arguments min_w_inf/max_w_inf to min_w_max/max_w_max and R_factor to reproduction_level - Update rate function calls (getMort(), getERepro()) - Fix matrix dimensions and species subsetting across evoProject() and plot functions - Set up testthat 3.0 test suite with 42 passing tests - Configure and build pkgdown documentation website
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR upgrades
mizerEvolutionto be fully compatible withmizer3.4:1. Package Configuration & Documentation
mizer (>= 3.4.0), addedlifecycletoImports:, removedmethods, configuredtestthat(>= 3.0.0, edition 3), and added package URL and BugReports.0.1.0._PACKAGEroxygen documentation, cleaned up imports, and registered global variables.docs/.2. Core Evolution Mechanics & Constructors
min_w_inf/max_w_inftomin_w_max/max_w_max, andR_factortoreproduction_level(withlifecycle::deprecate_warnfor backward compatibility).recordExtension().species_params(),gear_params(),resource_params()).with_info_level().mAmplitude,eta,z0pre,h,f0,resident_params).3. Plotting Functions
MizerSimusinginherits().getERepro(),getMort()).plotDynamics,plotSS,plotevoFeeding,plotevoGrowth,plotStarvation,plotevoMortality,plotSpawn,plotPredRate,plotPredMort,plotevoTrait).4. Tests & Quality Assurance
expect_s3_class()).evoParams(),extinctionRDD(),alien_synthesis(),nameGenerator(),tempFun(),evoProject(), and all plotting functions (42 passing tests).devtools::check(): 0 errors, 0 warnings, 0 notes.