Repository navigation
Open a view at the top when it fills in after starting empty - #25
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening a feed could land on the caught up footer instead of the first item.
Cause
select()first shows the stored ids for the view, which can be an empty list, then refreshes. The scroll rule only jumped to the top when the previous snapshot was non-empty (!shownIds.isNullOrEmpty()), so going from empty to filled kept theLazyListStateindex from the previous view, which pointed at the footer.Fix
TopOnNewSnapshot(ids, listState).Tests
TopOnNewSnapshotTestcovers the first snapshot keeping its position, a changed snapshot starting at the top, and a view that opens empty then fills. The last one fails with the old guard. Unit tests, lint andassembleReleasepass.