Repository navigation
Keep unread rows from showing a faded icon - #33
Merged
Merged
Conversation
Some unread rows showed their feed icon dim but in colour, the see-through part of the read look without the grey. The fade was a separate alpha layer that came and went with the read state, and on a device it stayed behind on some rows. The icon now fades through one colour filter that greys it and makes it see-through together, and the letter tile fades through its colours, so no layer is added or dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some unread rows showed their feed icon dim but still in colour: the 30% opacity of a read row without its grey. The fade was an alpha layer added and dropped with the read state, and on a Pixel it stayed behind on some rows after they were reused.
The icon now fades through a single colour filter that greys it and lowers its alpha together, and the letter tile fades through its colours, so there is no layer to leave behind.
The stuck layer did not reproduce under Robolectric, so the new FaviconFadeTest covers the expected states (read row grey, unread rows full colour after a read row turns unread, after a view switch and after scrolling past read rows) rather than the device glitch itself. Needs a check on the phone. 262 tests pass, lint clean.