Repository navigation
test(task-catalog): drop listTasks tests that repeat other tests - #237
Merged
Merged
Conversation
Co-authored-by: Toshi <toshi-noreply@coinbase.com> J-Engine-Session: je:e00141da-8385-4cd2-899f-04a870173b17
Collaborator
✅ Heimdall Review Status
|
Co-authored-by: Toshi <toshi-noreply@coinbase.com> J-Engine-Session: je:e00141da-8385-4cd2-899f-04a870173b17
Collaborator
Author
Review round 1Reviewers: cbhq-openai/gpt-6.1-sol (review: no findings); spec check: anthropic/claude-opus-5-5
🤖 Reply generated with Toshi |
jackchuma
marked this pull request as ready for review
November 7, 2026 04:31
0xth4nh
reviewed
Nov 7, 2026
0xth4nh
left a comment
Contributor
There was a problem hiding this comment.
Looks good to Thanh's Toshi
0xth4nh
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
Removes three
listTaskstests insrc/lib/__tests__/task-catalog.test.tsthat pin the same README parsing other tests already pin, and tightens the precedence test's last step. Test-only; production code is untouched.describe('listTasks') omits a Task with a regular-file network config… (pins READY TO SIGN, id, date) uses network, Task, then EVM README precedence (pins title, ## Description, READY TO SIGN, EXECUTED, no status) - expect(listTasks()).toEqual([{ …, status: undefined }]) + expect(JSON.parse(JSON.stringify(listTasks()))).toEqual([{ … }]) // status key absent after serialization - discovers active task folders without root-level network folders → covered by precedence + regular-file config tests returns pending status… (kept: only Pending assertion) - returns executed status… → covered by precedence step 2 - omits status when the README has no status line → covered by precedence step 3 + default-description test uses the default description… returns all active task folders… (also covers no root-level network folder layout)The JSON round-trip keeps the old
omits statustest's guarantee that serialized output has nostatuskey. It replacesstatus: undefined, whichtoEqualtreats as absent. A directnot.toHaveProperty('status')would be wrong: production explicitly returnsstatus: undefined(src/lib/task-catalog.ts), which JSON drops.The precedence test's network README now has a blank line after
## Description. The removed discovery test was the only one with that shape, which is what exercisescleanMarkdownBlock's leading-newline trim.Interfaces removed: none.
Notes to reviewers
git revertrestores the tests.How has it been tested?
status: nullfor the no-status case makes the widened precedence assertion fail (unexpected"status": null); reverted.^\n+trim incleanMarkdownBlockmakes the precedence test fail (received"\nNetwork description."); reverted.npm test -- src/lib/__tests__/task-catalog.test.ts: 44 passed.npx eslint,npx prettier --checkon the file andnpx tsc --noEmit: clean.Why this cleanup
## Descriptionwith leading/trailing trim, READY TO SIGN, EXECUTED, PENDING, absent status, default description) is pinned once.