Repository navigation
Conversation
…atalog J-Engine-Session: toshi:c3193bba-dcb1-44ce-98c1-8f0c9a44bf2f
✅ Heimdall Review Status
|
Review round 1Reviewers: cbhq-openai/gpt-6.1-sol
🤖 Reply generated with Toshi |
|
Validation: all 262 tests, the production build, lint, TypeScript, and formatting passed locally; the change matches CHAIN-6507. I checked the author's browser-check report, but did not independently repeat it or exercise live Forge/hardware-wallet flows. Reviewed 5a195e1: no remaining approval-blocking findings and relevant code/test CI is passing. @leopoldjoy approves based on this delegated review and will add a +1 when online. Posted by local automation on behalf of @leopoldjoy; the GitHub approval has not yet been submitted. |
0xth4nh
left a comment
There was a problem hiding this comment.
Looks good to Thanh's Toshi
|
Review Error for xenoliss @ 2026-11-17 16:05:23 UTC |
|
Review Error for xenoliss @ 2026-11-17 16:06:43 UTC |
…ing-task-catalog J-Engine-Session: toshi:c3193bba-dcb1-44ce-98c1-8f0c9a44bf2f
| throw error; | ||
| } | ||
| return entries | ||
| .filter(entry => entry.isFile() && entry.name.endsWith('.json')) |
There was a problem hiding this comment.
[P2] Preserve supported in-root profile symlinks (non-blocking)
Dirent.isFile() returns false for symlinks, so a validations/signer.json link to an in-root JSON file silently disappears from the picker. The previous route listed these, and loadProfile explicitly supports them. Preserve contained symlink-to-file entries while excluding directories and outside-root targets, and add listing regression coverage.
Posted by local automation on behalf of @leopoldjoy.
|
I confirmed symlinked profiles disappear from the picker and accept this as a non-blocking, unfixed residual. Current contract-deployments/main has no checked-in profile symlinks, ordinary profiles still work, and the UI stops rather than using another signing account, so a follow-up can preserve compatibility. Validation: all 280 tests, build, lint, TypeScript, and formatting pass; the symlink case was reproduced through the real catalog and route. Build passed on retry after an unchanged Next.js cache-advisory reminder (affected APIs are unused here). Prior browser evidence was checked; no independent browser, live Forge, or hardware-wallet run. Reviewed dc5253d: no remaining approval-blocking findings and relevant code/test CI is passing. @leopoldjoy approves based on this delegated review and will add a +1 when online. Posted by local automation on behalf of @leopoldjoy; the GitHub approval has not yet been submitted. |
Linear: https://linear.app/coinbase/issue/CHAIN-6507/validation-profile-listing-through-the-task-catalog
What changed? Why?
The profile listing route built Task paths and ran its own id and path checks. Those now live in the Task catalog, which gains
listProfiles(taskId, network). The route is a thin wrapper, and it no longer imports@/lib/deployments, which unblocks deleting that module (CHAIN-6510).listProfilesreturns{ name, displayName }[]for the.jsonfiles inconfig/<network>/validations, sorted by name. It never reads file contents, so a malformed Validation profile is still listed and fails later at validation.{ configOptions: [{ name, displayName }] }.ConfigOption.fileNameis renamed tonameto match. No components or props are renamed.Notes to reviewers
listProfilesinsrc/lib/task-catalog.ts, thenerrorResponsein the route.#227already removed file parsing andledgerIdfrom this route. This PR pins both with exact-equality tests.git revertundoes it. Blast radius: the profile picker in this app only.How has it been tested?
Tests run the real catalog on temp-dir fixture trees, with no fs mocks:
.json, sorted, display names), a malformed file, invalid ids, symlinks escaping the root, a missing Task or validations directory (not-found), and other fs errors propagating unchanged.Before: the new catalog tests failed with
listProfilesmissing or a rawENOENTwhere aTaskCatalogErrorwas expected. The route tests failed with 500 where 400/403/404 were expected, and with an emptyconfigOptionswhere profiles were expected.After:
npm test -- --runTestsByPath src/lib/__tests__/task-catalog.test.ts src/app/api/upgrade-config/__tests__/route.test.tspasses 65 tests.npm run lint,npx tsc --noEmit, andprettier --checkalso pass.Browser check (
npm run dev, headless Chrome, fixture Task withbase-signer.jsonand a malformedsecurity-council.json): both profiles are listed, the picker and summary showbase-signer, andPOST /api/validatesendsuserType: "base-signer". The fixture profile then fails schema validation, as expected for a stub file.