Repository navigation
fix(analytics): remember a visitor's Decline so "on" pages send nothing before the banner replays it - #363
Merged
Conversation
…ng before the banner replays it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
🚀 Package Preview Available!Install this PR's preview build with npm: npm i @base44-preview/sdk@0.8.58-beta.0-pr.363.6724db0Prefer not to change any import paths? Install using npm alias so your code still imports npm i "@base44/sdk@npm:@base44-preview/sdk@0.8.58-beta.0-pr.363.6724db0"Or add it to your {
"dependencies": {
"@base44/sdk": "npm:@base44-preview/sdk@0.8.58-beta.0-pr.363.6724db0"
}
}
Preview published to npm registry — try new features instantly! |
…d-Decline test Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
App mode On (
<meta name="base44-analytics" content="on">). A visitor declines in the app's cookie banner. On every following page load (real-browser test of@base44/sdk@0.8.58-beta.0on Cookie Lab Test, 2026-11-03):The SDK stores the id and sends one batch before the denial arrives.
Fix
base44_analytics_denied = "1". A denial writes it; a grant removes it.initialConsentGranted(mode):consent→ false;on→ not denied; else true. Used for the initialanalytics-consentstate.consent→onafter a Decline: the visitor stays untracked until they Accept. Intended: it honors their choice.Tests
New unit test in
analytics-consent.test.ts: after a Decline, the next "on" page stores and sends nothing; a later Accept clears the marker and starts tracking. Localnpm cifailed (local npm proxy 502 onfollow-redirects), so CI is the test run.Release
Ship in 0.8.58 (beta.0 already published from main 150fabb).
🤖 Generated with Claude Code