Repository navigation
Conversation
A high/critical advisory whose fixed version is still inside the Wix npm gateway's age block now shows as a warning instead of failing the job, since no lockfile change could pass both `npm ci` and the audit. The gate fails again on its own once the gateway serves the fix. Unreachable gateway or a missing audit report still fail. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
🚀 Package Preview Available!Install this PR's preview build with npm: npm i @base44-preview/sdk@0.8.59-pr.371.d7ccde1Prefer not to change any import paths? Install using npm alias so your code still imports npm i "@base44/sdk@npm:@base44-preview/sdk@0.8.59-pr.371.d7ccde1"Or add it to your {
"dependencies": {
"@base44/sdk": "npm:@base44-preview/sdk@0.8.59-pr.371.d7ccde1"
}
}
Preview published to npm registry — try new features instantly! |
…gateway" Keep follow-redirects 1.16.2 in the lockfile. CI stays red until the Wix gateway serves 1.16.2 (expected next week), then this PR merges as is. This reverts commit db8f865. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Security Audit fails on every run because of
follow-redirects1.16.1 (GHSA-mrwp-f3q8-3g9p, high). The fix, 1.16.2, can't be installed yet: the Wix npm gateway returnsE403for it while it's inside the gateway's age block for new versions. No lockfile can pass bothnpm ciand the audit until then, so the red check only adds noise and uses CI minutes. This came up in the GitHub Actions minutes thread as a workflow that fails constantly.Change
.github/scripts/audit-gate.mjsreadsnpm audit --omit=dev --json. For each high/critical advisory it asks the gateway which versions it serves; the full packument omits the versions it blocks. It then looks for one newer than the installed version and outside every advisory range.security-audit.ymlsaves the gateway IP before the existing unpin step removes it from/etc/hosts, then runs the script instead ofnpm audit --audit-level=high. The report-only full audit is unchanged.semver, so no new dependency.Verified
Tested locally with sample
npm audit --jsonfiles and the lockfile from #369:follow-redirects@1.16.1, 1.16.2 blocked by the gatewayaxios@1.13.0(gateway serves 1.13.5)npm auditerror, no reportThe real
npm auditcall wasn't run locally (it needs the gateway bypassed), so this PR's CI run is the end-to-end check.Note
CI is expected to fail until the Wix gateway serves
follow-redirects1.16.2 (it's inside the gateway's age block, so probably next week). Until then,npm cifails withE403onfollow-redirects-1.16.2.tgz, the same as onmain. Once the gateway serves it, CI should pass without changes and this PR can merge, so the next blocked fix shows as a warning instead of a failing job.🤖 Generated with Claude Code