Repository navigation
fix(updater): failed update check never blocks startup - #67
Merged
Merged
Conversation
The startup splash stopped on a full-screen 'Update check failed' card with Retry / Continue anyway, so an offline machine or any updater hiccup greeted users with an error before the app. The splash now opens the app on error and the taskbar update control (which already surfaces the failure and a retry) takes over. Updater failures are also logged to stderr with an [updater] prefix so packaged builds are diagnosable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while smoke-testing the v0.0.39 draft on macOS: when the update check fails (offline, a temp-dir/extract-path issue when run from
/tmp, a bad manifest), the startup splash blocks on a full-screen 'Update check failed' card before the user ever sees the app.StartupSplash: onerror, enter the app; the taskbarUpdateButtonalready shows the failure with retry. Removed the splash error card, its retry handler, 8 now-unused i18n keys (en, zh-CN; zh-TW regenerated) and its CSS.check_for_updates: log both failure paths to stderr with[updater]so packaged builds are diagnosable.Native verification on macOS: the v0.0.39 draft installed to
~/Applicationschecks, finds itself current, and opens straight into the new first-run sheet. A local 0.0.0 release build downloaded, installed, and relaunched into 0.0.38 end to end, so the macOS updater path works.Checks: tsc, check:i18n, check:ui-invariants; updater/first-run/get-started e2e.