Conversation
Sensitive Change Detection (shadow mode)This PR modifies control-plane files:
|
jeremy
left a comment
There was a problem hiding this comment.
CodeQL support for Go 1.27 coming in a release later this week.
Bump the toolchain across mise, go.mod, the smoke module, and the nix derivation (nixpkgs still carries 1.27rc3, so the existing conditional source-tarball override takes over until it catches up). golangci-lint moves v2.11.1 -> v2.13.1 in lockstep everywhere it is pinned: the old binary was built with Go 1.26 and refuses a 1.27 target, and v2.13.1's release binaries are built with Go 1.27.0.
The bats fixtures pinned v2.11.1, which the raised v2.13.1 floor now rejects.
|
Rebased onto main and pushed to Three conflicts, all bookkeeping: main moved the README's "From source" paragraph into docs/install.md, so the Go 1.27 wording went there; On the red checks: Locally on Go 1.27.0 with golangci-lint v2.13.1: |
Bumps the toolchain to Go 1.27.0 across everything that pins it:
.mise.toml,go.mod, andtests/smoke/go.modmove to 1.27.0. CI workflows readgo-version-file: go.mod, so they follow on their own.nix/go.nixmoves its base togo_1_27withminGo = "1.27.0"and the official source-tarball hash. The pinned nixpkgs only carries 1.27rc3, so the file's existing conditional override rebuilds from the upstream tarball and drops itself once nixpkgs catches up — the same pattern it used for 1.26.6.tools, both workflows, pre-commit, and theMIN_VERSIONfloor inscripts/check-lint-lockstep.sh). The old binary was built with Go 1.26 and refuses a 1.27 target; v2.13.1's release binaries are built with Go 1.27.0.make checkpasses in full locally: fmt, vet, lint (0 issues), all tests, tidy-check, surface snapshot, and both lockstep checks. The nix path is unverified locally (no nix on this machine) — the nix-build job is the check for that.Dependency
PR #304 is the cached-Go 1.26.6 foundation and should merge first. After it lands, sync this branch with current main before advancing #296. The PR base remains main for now; no history is rewritten while the foundation is under review.