Select threads with x as well as space - #359
Conversation
There was a problem hiding this comment.
Pull request overview
Adds x as a thread-selection shortcut and moves cover peeking to z.
Changes:
- Supports
xselection in mail and Previously Seen lists. - Updates cover controls and hints from
xtoz. - Adds tests for selection and cover behavior.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
internal/tui/mail.go |
Updates key routing and help bindings. |
internal/tui/mail_test.go |
Tests x selection and z cover toggling. |
internal/tui/covers_test.go |
Updates expected cover hints. |
internal/tui/content.go |
Changes rendered cover hints to z. |
internal/tui/calendar_views.go |
Updates a related comment. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| case "c": | ||
| return v.startCompose() | ||
| case " ", "space": | ||
| case " ", "space", "x": |
There was a problem hiding this comment.
Fixed in f1aa5b1: the no-selection notice now reads "Select threads with space or x before starting a bulk reply", and the assertion in bulk_reply_test.go pins the new text.
| case "n", "N": | ||
| return v.startCollectionPicker() | ||
| case "x": | ||
| case "z": |
There was a problem hiding this comment.
Fixed in f1aa5b1. The shortcuts moved from README.md to docs/tui.md on main; the rebase updated them there: the key table lists Space or x for selection, and the cover paragraph names z to peek and z again to close it.
The HEY desktop app selects a thread in the list with x; the TUI only answered to space. x now toggles the selection in the box list and on the Previously Seen screen, matching the app. x was the cover peek's key, so the peek moves to z — the cover hints in the section headers and the help bar move with it.
…k key The bulk-reply notice, the cover picker footer and docs/tui.md still named the old keys: space alone for selection and x for the peek. basecamp#399 fixed the picker footer to name the real peek key; that key is z now, so the footer follows it.
d06801e to
f1aa5b1
Compare
|
Rebased onto main ( The Review threads. The bulk-reply notice now says "Select threads with space or x", with its test updated; the shortcut docs moved from README.md to docs/tui.md on main, and both references there (the key table and the cover paragraph) now name
|
The HEY desktop app toggles a thread's selection with
x; the TUI only answered tospace. For parity,xnow toggles the selection too, in the box list and on the Previously Seen screen. The help bar shows the pair asspace/x select.xwas previously the cover peek's key on a covered Imbox, so the peek moves toz: the section-header hints ("z to peek" / "z to cover") and the help bar move with it.Tests cover
xselecting (and not lifting the cover) in both lists, and the cover peek tests now exercisez.make checkpasses.Summary by cubic
Makes
xtoggle a thread's selection in the box list and Previously Seen screen, matching the HEY desktop app;spacestill works. The cover peek key moves fromxtoz, with the help bar, section-header hints, docs, and notices updated accordingly.xtoggles selection without affecting the cover state.xselection in both lists andzcover peeking.Written for commit f1aa5b1. Summary will update on new commits.