Bump mr-boxington-action to v1.3.1 and mbx to 1.11.1 - #193
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟢 Approved
The pinned release implements and bundles the documented default before any mbx invocation.
Pull request overview
Updates the Rust CI cache action to v1.3.1 and relies on its hosted-runner GC default.
Changes:
- Pins
mr-boxington-actionto v1.3.1. - Removes redundant job-level
MBX_GC_AUTO=0. - Documents the action’s new default.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
File summaries
| File | Description |
|---|---|
.github/workflows/test.yml |
Updates the cache action and removes redundant configuration. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The action resolves the immutable release and checks the archive against the digest GitHub reports for it. cache-generation stays: the store crate is unchanged between 1.10.1 and 1.11.0, and the C objects #429 re-keys are relearned on the first run, as the 1.10.1 prediction namespace was.
1.11.1 bounds learned incremental storage under GC, refuses NFS-backed build storage, keeps cargo install --path fingerprints, and rotates full action-prediction manifests as an LRU instead of refusing new work. None of it changes what the store holds or how objects are keyed (the store crate's diff is manifest export order and import merging; mbx-cache-core's digest, path-mapping and local CAS modules are untouched), so cache-generation carries over.
mbx 1.11.1 runs a cargo metadata probe before every managed cargo command and forwards --config to it, so the conformance runner's `mbx deny --config ../../../rust/deny.toml` now fails: cargo rejects deny.toml as a config file (licenses.confidence-threshold is a float) and 1.11.1 makes a failed probe fatal instead of passing through. cargo-deny reads deny.toml from the working directory, so run it from rust/ and name the conformance manifest instead.
e469c8a to
e9deba1
Compare
|
Re-pinned from mbx 1.11.0 to 1.11.1 (e9deba1, rebased onto main at 5817850, no conflicts). Generation carried over. The v1.11.0...v1.11.1 diff touches One 1.11.1 behaviour change reached this job. mbx now runs a Rebase. CodeQL default setup started analysing JavaScript/TypeScript once main gained Local checks (macOS arm64, mbx 1.11.1 downloaded and sha256-verified against the release digest):
Copilot last reviewed 865a1f9; a re-review needs a human to request it. |
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Bumps
jdx/mr-boxington-actionfrom v1.3.0 to v1.3.1 (a20e1ff), bumps mbx from 1.10.1 to 1.11.1 in the Rust Tests job, and drops the job'sMBX_GC_AUTO: "0"env, which the action now sets itself.From the v1.3.1 release note: "For
backend: githubwithgithub-cache-mode: objects, the action now defaultsMBX_GC_AUTO=0whenRUNNER_ENVIRONMENTisgithub-hostedand the variable is unset, exporting it before invoking mbx so it applies for the whole job." That is the workaround #188 added by hand, upstreamed (jdx/mr-boxington-action#37).Checked against the action at the pinned commit:
githubObjectGcDefaultinsrc/lib.tsreturns"0"exactly for our configuration (defaultbackend: github,github-cache-mode: objects,ubuntu-latestisgithub-hosted), andmain()exports it beforesetupMbxruns. No step in the job runs mbx before the action, so nothing depended on the job-level env being set earlier. An explicitMBX_GC_AUTOwould still be respected, so the env can come back if a different value is ever wanted.mbx 1.11.0 collapses equivalent C include roots (jdx/mr-boxington#429) so aws-lc's amalgamated bcm.c fits the manifest budget and caches; 1.11.1 bounds learned incremental storage under GC (jdx/mr-boxington#447), refuses NFS-backed build storage (jdx/mr-boxington#428), keeps
cargo install --pathfingerprints (jdx/mr-boxington#455) and rotates full action-prediction manifests as an LRU instead of refusing new work (jdx/mr-boxington#453, jdx/mr-boxington#456).cache-generationcarries over: the v1.11.0...v1.11.1 diff touches the store crate only for manifest export order and import merging, and mbx-cache-core's digest, path-mapping and local CAS modules are untouched, so 1.11.1 stores the same objects under the same keys. The action resolvesversionagainst the immutable release and checks the archive against GitHub's asset digest; v1.11.1 is immutable with sha256 digests on every asset.One 1.11.1 change does reach this job: mbx now runs a
cargo metadataprobe before every managed cargo command, forwards--configto it, and treats a failed probe as fatal. The conformance runner'smbx deny --config ../../../rust/deny.tomlfails that probe (cargo rejects deny.toml as a config file), sorust/Makefilenow runs cargo-deny fromrust/with--manifest-path ../conformance/runner/rust/Cargo.toml, which reads the same deny.toml from the working directory. Reproduced and verified locally with the digest-checked mbx 1.11.1 macOS build:make deny CARGO=mbxfails on the old form and passes on the new one, and plaincargo denyaccepts the new form too. actionlint and zizmor 1.30 pass locally.Summary by cubic
Bumps
jdx/mr-boxington-actionto v1.3.1 andmbxfrom 1.10.1 to 1.11.1 in the Rust Tests job, so the action now provides theMBX_GC_AUTO=0default and the aws-lc bundle fits the cache manifest.MBX_GC_AUTO: "0"env, which the action now sets for object-mode GitHub-hosted jobs.bcm.cfits the cache; 1.11.1 doesn't re-key stored objects, socache-generationcarries over.make denyto run cargo-deny fromrust/with--manifest-path ../conformance/runner/rust/Cargo.toml, because mbx 1.11.1's mandatorycargo metadataprobe rejectsdeny.tomlas a--configfile.Written for commit e9deba1. Summary will update on new commits.