refactor: Migrate the last 2 test_misc.sh cases to Bazel-native sh_test - #1946
Draft
bor-p-s wants to merge 2 commits into
Draft
refactor: Migrate the last 2 test_misc.sh cases to Bazel-native sh_test#1946bor-p-s wants to merge 2 commits into
bor-p-s wants to merge 2 commits into
Conversation
…st, delete the file
bor-p-s
force-pushed
the
bor-p-s/test_misc_last
branch
from
August 27, 2026 07:39
e5e8af2 to
d84889b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#1921 migrated 5 of
test/shell/test_misc.sh's 7 cases and lefttest_override_javabinandxmllint_testfor a follow-up. This is that follow-up, and it deletes the file (and itstest_rules_scala.shline) for good.test_override_javabinbecomes a bespokesh_test(test/override_javabin), following the samenested_bazel.shpattern #1943 used for abazel run-based case: it setsJAVABIN=/etc/basdfbefore a nestedbazel run //test:ScalaBinaryand asserts the run fails. None of the 4expect_build_failure.bzlmacros fit, since none of them wrapbazel run.JAVABINis read by the bash launcherscala_binary/scala_testgenerate (phase_java_wrapper.bzl); on Windows Bazel uses a native.exelauncher instead that doesn't consult it, so the target istarget_compatible_with-excluded there, matching the original'sis_windowsskip.xmllint_testis dropped, not migrated. It validated that XML files underbazel-testlogs-- generated by every other test in the old shell suite's run -- were well-formed. That's not something onesh_testcan check: it only sees its own run's output, not the whole suite's. The check itself was validating Bazel's own test-result XML output, which Bazel already treats as its own schema-versioned format to maintain; there's no known case of Bazel producing malformed test-result XML, so this looks like a leftover safety check rather than something specific to rules_scala.Motivation
Release impact: tests only.