Skip to content

Close the GrpcRemoteDownloader's channel at the end of a command - #31192

Open
fmeum wants to merge 1 commit into
bazelbuild:masterfrom
fmeum:claude/bazel-remote-downloader-leak
Open

fmeum wants to merge 1 commit into
bazelbuild:masterfrom
fmeum:claude/bazel-remote-downloader-leak

Conversation

@fmeum

@fmeum fmeum commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator

Description

RemoteModule never closed the GrpcRemoteDownloader it created for a command, so the reference it held on its gRPC channel was leaked and the channel (a dedicated one for --remote_downloader, or the one shared with --remote_cache) was never shut down.

Motivation

Build API Changes

No

Checklist

  • I have added tests for the new use cases (if any).
  • I have updated the documentation (if applicable).

Release Notes

RELNOTES: None

`RemoteModule` never closed the `GrpcRemoteDownloader` it created for a command, so the reference it held on its gRPC channel was leaked and the channel (a dedicated one for `--remote_downloader`, or the one shared with `--remote_cache`) was never shut down.
@fmeum
fmeum requested a review from a team as a code owner September 18, 2026 09:05
@github-actions github-actions Bot added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Sep 18, 2026
@fmeum

fmeum commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator Author

@bazel-io fork 9.3.0

@coeuvre coeuvre added copybara:import Trigger copybara to import the PR and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 18, 2026
@bazel-docs-pr-commenter

Copy link
Copy Markdown

❌ Bazel docs preview deployment failed (Mintlify result: timed_out).

Please check the GitHub Actions logs for details.

Updated for 2fffa0e9359040dbeee05b1eeff7fed1927a34ec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copybara:import Trigger copybara to import the PR team-Remote-Exec Issues and PRs for the Execution (Remote) team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants