Conversation
Cache immutable Starlark attribute values on ConfiguredAttributeMapper for outgoing transitions. Intern ParsedFlagsValue merge-cache keys with BuildConfigurationKey and keep values weak so no-op merges do not retain their keys. RELNOTES: None
github-actions
Bot
added
team-Configurability
meisterT
reviewed
Sep 18, 2026
| Caffeine.newBuilder().weakKeys().build(this::mergeWithImpl); | ||
| // Weak keys use identity. Intern equivalent inputs so temporary option copies share entries. | ||
| // Values are weak too: a no-op merge returns its input key. | ||
| private final LoadingCache<BuildConfigurationKey, BuildConfigurationKey> mergeCache = |
Member
There was a problem hiding this comment.
It might be worth splitting this out into a separate PR as it is independent. Also would make easier to benchmark the two changes in isolation.
Member
|
I wonder how our build setup is different - I was not able to see any performance gain of analysis of big targets in Google3 during my own benchmarking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache immutable Starlark attribute maps on
ConfiguredAttributeMapperand use internedBuildConfigurationKeyobjects with weak keys and values in the parsed-flags merge cache. In our partial-analysis benchmark on Bazel 9.3, mean analysis time fell from 124.30 to 111.28 seconds (10.5%); reduced GC contributed to the difference.Validation: targeted Starlark transition and parsed-flags tests passed against
master.RELNOTES: None
-zbarskybot