fix: stops logging relations to types the run did not read as errors - #576
Merged
semx merged 1 commit intoOct 5, 2026
Merged
Conversation
Interfaces and power ports reference their NetBox module. Only the check_redfish source reads modules from NetBox. A VMware only run therefore logged "Problems resolving relation 'module'" for every interface and power port with a module. NetBox 3.3 to 4.2 has modules, but the module type is only read from 4.3. There check_redfish logged the same errors. The inventory now records the object types read from NetBox. The resolver resolves relations as before. It logs an error only when the type was read and the object is still missing. Otherwise the value stays as NetBox returned it. The errors were log noise only. A VMware sync never sets or unsets the module, so no request changes it.
semx
approved these changes
Oct 5, 2026
semx
left a comment
semx
left a comment
Collaborator
There was a problem hiding this comment.
Thanks Marcin. The vcsim test reproduces the report on development (12 and 8 "Problems resolving relation 'module'" errors on the two fixtures) and passes here; the full suite is green (263 passed). Merging; it goes out as 1.9.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interfaces and power ports reference their NetBox module. Only the check_redfish source reads modules from NetBox.
A VMware only run therefore logged "Problems resolving relation 'module'" for every interface and power port with a module. NetBox 3.3 to 4.2 has modules, but the module type is only read from 4.3. There check_redfish logged the same errors.
The resolver resolves relations as before. It logs an error only when the type was read and the object is still missing. Otherwise the value stays as NetBox returned it.
Added
NetBoxInventory.load_from_netbox()so it would be a single place to change it.Closes #575