Repository navigation
feat: use shared gitleaks rules from bcregistry-sre - #285
Merged
Merged
Conversation
Pulls the gitleaks rules from bcgov/bcregistry-sre (git-hooks/, added in bcregistry-sre#407) via lefthook remotes, same as ppr#2380. This adds the shared hardcoded-password and custom-password rules on top of the gitleaks defaults; .gitleaks.toml now extends the shared base and keeps only this repo's own allowlist. The secret-scan command blocks the commit if the shared rules haven't been downloaded, instead of scanning with no rules. Also drops the pre-commit lint command: there is no lint-staged config in this repo, so it failed every commit touching js/ts/vue/css/md. Linting stays in CI, same as ppr after the lint step was removed there.
pwei1018
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the Git Hooks RFC rollout (bcgov/entity#34619).
Switches the hook to the shared gitleaks rules in bcgov/bcregistry-sre (
git-hooks/, added in bcgov/bcregistry-sre#407), same as bcgov/ppr#2380. Rule changes now get made once in sre and every repo picks them up within a day.lefthook.yml- adds the bcregistry-sreremotes:entry. The scan blocks the commit if the shared rules haven't been downloaded yet, instead of scanning with no rules..gitleaks.toml- extends the shared rules (gitleaks defaults + Patrick'shardcoded-password+ Thor'scustom-password) instead of just the defaults. No new allowlist entries needed - the password rules find nothing new in the existing tree.README.md- one sentence on where the rules come from + the Windows long-paths note.Also fixes the hook on main: the pre-commit
lintcommand (npx -y lint-staged, from #281) has no lint-staged config in this repo, so it fails every commit touching js/ts/vue/css/md for anyone with hooks installed (checked on a clean clone of main). Removed it - linting stays in CI, same as ppr after its lint step was dropped. With this PR.md/.tscommits go through and secrets are still blocked.Nothing changes for setup:
pnpm installat the repo root once. On Windows rungit config --global core.longpaths trueonce first.Tested
Real
git commiton Windows, pnpm 11.9.0, fresh clone:os.getenv(...),process.env.X→ commit finecore.longpaths) → blocked with "Shared gitleaks rules missing", recovers once fixedDoesn't touch app code, so CI/build should be unaffected.