Repository navigation
feat: use shared gitleaks rules from bcregistry-sre - #322
Merged
Merged
Conversation
Pulls the gitleaks rules from bcgov/bcregistry-sre (git-hooks/, added in bcregistry-sre#407) via lefthook remotes, same as ppr#2380. This adds the shared hardcoded-password and custom-password rules on top of the gitleaks defaults; .gitleaks.toml now extends the shared base and keeps only this repo's own allowlists. The secret-scan command blocks the commit if the shared rules haven't been downloaded, instead of scanning with no rules.
kialj876
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls the gitleaks rules from bcgov/bcregistry-sre (git-hooks/, added in
bcregistry-sre#407) via lefthook remotes, same as ppr#2380. This adds the
shared hardcoded-password and custom-password rules on top of the gitleaks
defaults; .gitleaks.toml now extends the shared base and keeps only this
repo's own allowlists. The secret-scan command blocks the commit if the
shared rules haven't been downloaded, instead of scanning with no rules.
Two new allowlists for the only new matches in the tree:
docs/sb-manager/- generated Storybook output, same as the existingdocs/assets/entryRESET_PASSWORD = 'RESET_PASSWORD'enum valueTested with real commits after
npm cion a fresh clone: allowlisted lines andprocess.env.Xpass; literal passwords, near-miss enum values and a fake GitHub token are blocked; with the shared rules missing and GitHub unreachable the commit is blocked with "Shared gitleaks rules missing".