Repository navigation
#34716 fix: added none to empty func on reciept retrieval - #2032
Merged
Merged
Conversation
Oluwapizzy
requested review from
davemck513,
mengdong19,
ozamani9gh and
stevenc987
as code owners
October 16, 2026 22:12
|
stevenc987
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#34716
Description of changes:
The receipts endpoint returns 500 when Pay sends invoiceNumber and receiptNumber as null. That happens for a PAD, EFT, EJV, or internal invoice that is approved but not settled yet. The emailer calls POST /payments/{id}/receipt to attach the PDF. Namex loads the Pay payload into ReceiptResponse, and Pydantic rejects the nulls because those two fields are plain strings. The PDF is never built, and the payment email goes out without the receipt.
ReceiptResponse now turns a null invoice number or receipt number into an empty string before validation. A real number is left as it is. Card payments already send real numbers, so that path is unchanged. The debit and the name-request status are not part of this change.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the namex license (Apache 2.0).