Repository navigation
feat. implement cloud run deployment for Express-Checkout - #396
Merged
Merged
Conversation
ochiu
approved these changes
Oct 22, 2026
Jxio
reviewed
Oct 22, 2026
| /^api\/v[12]\/payment-links\/[^/]+\/(transactions|receipts)$/, | ||
| /^api\/v[12]\/payment-requests\/\d+\/transactions\/[^/]+$/ | ||
| ] | ||
| const BEARER = /^Bearer \S+$/ |
Collaborator
There was a problem hiding this comment.
is Bear token might be null or undefined?
Collaborator
Author
There was a problem hiding this comment.
This validation only checks the format of the header. Literal values such as Bearer null or Bearer undefined would still match the pattern. If we need to reject those values, I can add additional validation logic or explicitly parse and validate the token.
Jxio
approved these changes
Oct 22, 2026
sumesh85
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #: bcgov/entity#35321
Description of changes:
This pull request introduces significant updates to the
express-checkoutapplication, focusing on modernizing the build and deployment pipeline, enhancing security and environment configuration, and upgrading dependencies for better maintainability and compatibility. The changes transition the project to Nuxt 4, update Docker and environment handling for production readiness, and improve security practices, especially around redirects and sensitive configuration.Key changes include:
Build and Deployment Modernization
nuxt.config.ts, including SSR configuration and long-term caching for static assets. Content-Security-Policy is now managed at runtime via environment variables.