Skip to content

Spend time more evenly - #441

Merged
bdmendes merged 1 commit into
masterfrom
time-evenly
Apr 19, 2026
Merged

bdmendes merged 1 commit into
masterfrom
time-evenly

Conversation

@bdmendes

@bdmendes bdmendes commented Apr 19, 2026 •

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Improvements
    • Refined engine time allocation per move for more balanced time management during gameplay.

@coderabbitai

coderabbitai Bot commented Apr 19, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 83e96d2f-dbfa-4ac9-b224-e67124e64f19

📥 Commits

Reviewing files that changed from the base of the PR and between daa9a9e and 45491ee.

📒 Files selected for processing (1)
  • src/engine/time.rs

Walkthrough

Modified move-time scaling calculations in get_duration_based_on_moves function within the time module. Baseline divisor adjusted from time / 20 to time / 16. Multiplier clamp range changed from [0.8, 1.4] to [0.9, 1.3]. No structural or control flow changes.

Changes

Cohort / File(s) Summary
Move-Time Scaling Constants
src/engine/time.rs
Adjusted baseline divisor from time / 20 to time / 16 and multiplier clamp range from [0.8, 1.4] to [0.9, 1.3] in get_duration_based_on_moves function.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Poem

🐰 A nibble here, a tweak just there,
Time constants floating through the air,
From twenty down to sweet sixteen,
Clamps compressed so sharp and keen,
The finest tuned move-math you've seen! 🎲⏱️

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Spend time more evenly' directly relates to the main change of adjusting move-time scaling constants to create more balanced time allocation across moves.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Apr 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92%. Comparing base (daa9a9e) to head (45491ee).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff          @@
##           master   #441   +/-   ##
=====================================
  Coverage      92%    92%           
=====================================
  Files          33     33           
  Lines        3757   3757           
  Branches     3757   3757           
=====================================
  Hits         3419   3419           
  Misses        319    319           
  Partials       19     19           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Apr 19, 2026 •

Copy link
Copy Markdown

Against master [hash=64]: 🆗 Elo: 14.95 +/- 16.60, nElo: 19.43 +/- 21.53

@github-actions

github-actions Bot commented Apr 19, 2026 •

Copy link
Copy Markdown

Against v1.6.0 [hash=64]: ✅ Elo: 62.51 +/- 19.00, nElo: 72.45 +/- 21.53

@bdmendes
bdmendes merged commit be20971 into master Apr 19, 2026
8 checks passed
@bdmendes
bdmendes deleted the time-evenly branch April 19, 2026 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant