fix: manage set commands through set_registry for making set commands… - #1046
Draft
wakonig wants to merge 1 commit into
Draft
fix: manage set commands through set_registry for making set commands…#1046wakonig wants to merge 1 commit into
wakonig wants to merge 1 commit into
Conversation
wakonig
force-pushed
the
fix/active_set_registry
branch
from
September 10, 2026 09:43
db9eb74 to
a9aa724
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR bec-project/ophyd_devices#227 in ophyd devices introduced a patched ophyd signal to (finally) make ophyd signal's .set command stoppable by using a global registry for currently active .set commands. While PSIDeviceBase already uses this patch, this PR extends its usage for all devices. Consequently, any stop() call will now cancel the underlying .set command. Same is true for .destroy().
Type of Change
How to test
Potential side effects
[Describe any potential side effects or risks of merging this PR.]
Screenshots / GIFs (if applicable)
[Include any relevant screenshots or GIFs to showcase the changes made.]
Additional Comments
[Add any additional comments or information that may be helpful for reviewers.]
Definition of Done