Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Contributor
Benchmark comparisonThreshold: 20% (lower is better). No benchmark regression exceeded the configured threshold. No benchmark improvement exceeded the configured threshold. All benchmark results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deliver weak dispatcher callbacks through Qt receiver contexts. Cancel queued data immediately and defer native relay deletion until in-flight emitters release it. Preserve receiver migration and modal RPC delivery. Waveform reads subscription context from metadata; log ingestion no longer requires a Qt sender.
Related Issues
None linked.
Type of Change
How to test
QT_QPA_PLATFORM=offscreen python -m pytest -p no:xvfb -p no:cacheprovider --random-order -q tests/unit_tests/test_{bec_dispatcher,bec_widget_lifecycle,bec_connector,rpc_server,waveform,logpanel,image_view_next_gen}.py320 tests passed, including 5,000 producer/cancellation iterations and 10,000 GC/invalidation iterations in subprocess regressions. These check cancellation, eventual relay release, and absence of native crashes.
Potential side effects
Plugins using dispatcher callbacks must replace
sender().cb_infowithmetadata["cb_info"]and removeverify_sender=True.Screenshots / GIFs (if applicable)
N/A — no layout changes.
Additional Comments
CLI/Designer regeneration produced no diff. Follow-up fixes remain local, uncommitted and unpushed.
Definition of Done