Repository navigation
Release 1.0 - #79
Draft
eivinhb wants to merge 7 commits into
Draft
Release 1.0#79eivinhb wants to merge 7 commits into
eivinhb wants to merge 7 commits into
Conversation
java.util.Date and java.util.Calendar is old now and we don't want to use that any more. Breaking changes: We use ZonedDateTime in stead of Date to represent a date to check for working days. The list of holidays are now a NavigableSet<LocalDate> and not a Date[]. Co-authored-by: tobiasgwaaler Co-authored-by: runeflobakk Co-authored-by: martin-jackson Co-authored-by: hhaga Co-authored-by: fredrbus
Breaking change: Du må erstatte java.util.Date med java.time.LocalDate. Gjorde i tillegg en liten endring i Person::getFodselsDato slik at LocalDate-en som returneres har riktig århundre. Beregning av fødselsdato fra fødselsnummer blir riktignok deprecated i pull requesten nedenfor, men metoden får vel leve en liten stund til. #74
Kjønn vil slutte å være et konsept i 2032 i sammenheng med fødselsnummer. Vi forbereder oss allerede nå ved å ta vekk konseptet i god tid. Siden kjønn forsvinner fra fodselsnummer har vi ingen måte i Person-klassen å identifisere om det er mannsnavn eller kvinnenavn. jeg fjerner derfor enkelt og greit denne funksjonen fra Person.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jeg tenker ta ut en release candidate her straks. Jeg har rebaset branchen på master, så endringer der skal være med.
Det er fremdeles endel deprekerte metoder i fødselsnummer. Foreløpig har vi ikke noe plan for hvordan dette skal løses, men det har vi noen år på.
Nå er i hvert fall kjønn fjernet samt java.time er på plass.