simplify pending links in io_str - #1303
Merged
Merged
Conversation
toprameen
marked this pull request as ready for review
October 3, 2026 23:59
Lorenzobattistela
self-requested a review
October 4, 2026 11:53
Lorenzobattistela
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
io_strnow tracks the next writable string link with a pointer, replacing the tail offset sentinel and guarded finalization. The root remains unsealed, tail sealing followsSConhotness, and UTF-8 decoding and allocation order are unchanged.Local checks: 12 native macOS fixtures under UBSan/bounds and 13 JS fixtures pass on both versions. Extracted-function comparisons match across 2,426,440 hot/non-hot cases. Generated C differs only in
io_str; JS output is unchanged. The repo gate and whitespace check pass, and local runtime benchmarks show no regression.