Repository navigation
Roots share their ~ constants, so a template goes to the kernel once instead of once per root that uses it - #1358
Merged
Lorenzobattistela merged 1 commit intoOct 6, 2026
Conversation
…instead of once per root that uses it Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Lorenzobattistela
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
--verdictchecks a template likedef pair(~a: Nat, ~b: Nat)at made-up constantspair~a,pair~b. Every root gets its own made-up constants, and every template it calls is copied at them. So inpairgoes to the kernel twice: once atpair~a, pair~b, once atother~x, other~y. A template used by 18 roots goes 18 times, with everything it calls.Fix
A root reuses the constant an earlier root made for the same place and type. Above,
otherchecks atpair~a, pair~b, andpair(~x, ~y)is the copy that is already there.This is safe because:
{a == b}still does not check).Numbers
Our book (generated square-packing proofs, 2.4 MB), on main (d052d4f), same machine:
-o)gates/safe_node.tson all 1580 files intests/prints exactly the same output as main.Note on #1263
#1263 lets a root change the models of its constants after the fact. With shared constants, that change would also affect other roots, so a root that needs such a change should get its own constants again. If #1263 lands first, I will add that to this PR.
🤖 Generated with Claude Code