Repository navigation
feat(web): notes picker reaches down to C3, one row per octave - #33
Merged
Merged
Conversation
The picker offers C3 to C5 (midi 48-72, 25 chips) instead of one octave from C4. The default stays C4, now mid-range so intervals reach up or down. Chips break into rows at the octave (C3-B3, then C4-C5). Share links accept the wider range; tests, README and spec updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?n=share links accept the wider range (below C3 / above C5 still dropped).Validation
cargo fmt --all --check,cargo clippy,cargo test— pass (one pre-existing clippy warning in untouched code)vitest376/376,svelte-check0 errors#/notes?n=48,60,67: rows break at C4, C3 plays as the root