Repository navigation
feat(web): notes picker reaches C6, plus a chord mode - #34
Merged
Merged
Conversation
…n the pressed note The picker spans C3 to C6 (37 chips, one row per octave). A new Pick select offers Single notes or one of six triads (Major, Minor, Diminished, Augmented, Sus2, Sus4); in chord mode a chip press replaces the pick with that triad, the root again clears it, roots whose triad would pass C6 are aria-disabled with a hint, and changing the chord re-voices the current root. Share links carry c=<chord>; Reset returns to single notes. Tests, README and spec updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
web/src/lib/notes/chords.ts).aria-disabledwith a hint. Changing the chord re-voices the current root; switching back to Single notes keeps the pick.&c=<chord>; unknown ids are dropped; Reset returns to Single notes.Validation
cargo fmt --check,cargo clippy,cargo testpass (clippy's one warning is pre-existing, in untouched code)vitest391/391 (newchords.test.ts+ 9 chord-mode component tests),svelte-check0 errors#/notes?n=57&c=minor→ pressing D4 gives D4/F4/A4 and?n=62,65,69&c=minor; F♯5 and above greyed out; no console errors