Repository navigation
Don't cancel CI runs on main - #304
Merged
Merged
Conversation
Two merges in quick succession cancelled the first one's CI run, which left that commit on main with cancelled checks and a failed "CI OK". Runs for pull requests still cancel the older run when a new commit arrives.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When #303 merged a minute after #302,
cancel-in-progresscancelled the CI run for #302's merge commit. Its "CI OK" job then failed because its needs were cancelled, so that commit on main showed red. I re-ran it, and it's green now.The concurrency group is now the commit SHA for pushes, so runs on main never cancel or queue behind each other. Pull requests keep the branch ref as the group, and a new push still cancels the older run. Just turning off
cancel-in-progresswouldn't be enough: GitHub still cancels a queued run when a third one arrives in the same group.