Repository navigation
Conversation
The desktop sign-in (#295) needs the same RS256 and MFA claim checks as the web server. Move the module unchanged so both can import it; the web server's platform identity service now imports it from src/shared/auth. No behavior change. The module stays Node only (node:crypto), which its new header states so the renderer does not import it.
This was referenced Oct 29, 2026
robspan
marked this pull request as ready for review
October 29, 2026 10:25
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of three PRs for the desktop platform sign-in (#295), as agreed in the issue:
platform-jwtmoves tosrc/shared/before anything else.What
src/web/server/platform-jwt.tsmoves unchanged tosrc/shared/auth/platform-jwt.ts, with a header that says it is Node only (node:crypto), so the renderer does not import it. The web server's platform identity service imports it from there.Existing files touched
src/web/server/platform-identity.tsVerification
Against
mainat779a6d25(v0.91.0):electron-vite build:out/main(55 of 55 files),out/preload(1 of 1) andout/renderer(114 of 114) are byte-identical tomain.mainandrendererprojects), compared test by test withmain: no test changes status.Stack