Repository navigation
Add light theme, keep code dark - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a light theme alongside the already existing dark theme; its hue is similar to it. It is set to adhere to the OS setting.
Changes
light-dark()function (2024 baseline), with fallbacks, is used.--surface-codeis now#121115instead of a translucent tint: it appeared gray in light mode.pre) & code tabs use dark-theme colors in both themes.Things to know
theme-darkto non-precode elements that should appear dark in light mode. Without it, their text and controls use the light-theme colors.@supportsfallback forlight-dark()function is temporary. Colors currently need to be changed in two places. I suggest removing it if supporting browser versions older than May 2024 is not a priority. The fallback wasn't tested.