fix(mobile): prevent FlashList unmount crash on station change - #754
Open
sentry[bot] wants to merge 1 commit into
Open
fix(mobile): prevent FlashList unmount crash on station change#754sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the
IllegalStateException: addViewAtcrash occurring on Android inapps/mobile/src/screens/route-list/route-list-screen.tsx.Root Cause:
The crash was caused by the FlashList being unmounted mid-navigation transition when the
[originId, destinationId]effect calledsetRouteData([])upon station changes. This led to React Native Fabric attempting to insert a view that was still attached to the outgoing fragment, triggering theaddViewAterror. This was a regression, as a previous fix (PR #689) had already addressed this by keeping the list mounted.Solution:
This fix restores the approach from PR #689:
setRouteData([])from the[originId, destinationId]effect: The FlashList is no longer torn down when stations change, preventing the mid-transition unmount.routeDataStationsstate: This state now tracks the{ originId, destinationId }for which the currentrouteDatawas fetched.trains.isSuccesseffect: When new data arrives for different stations (detected by comparing withrouteDataStations),routeDatais now replaced entirely instead of being merged.routeDataStationsis updated accordingly.routeDataStationsin the[time, hideSlowTrains]effect: Ensures that a full refresh (e.g., changing the date or filter) correctly clears the station tracking.Fixes BETTER-RAIL-37
This PR was automatically generated by Sentry. You can adjust this setting at any time.