fix(mobile): stretch context menu content to full width - #767
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe mobile ChangesContext menu full-width rendering
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant ContextMenu
participant FillWidth
participant NativeMenu
ContextMenu->>FillWidth: render with width callback
FillWidth->>FillWidth: measure container width
FillWidth->>NativeMenu: render content with measured width
NativeMenu->>ContextMenu: invoke onPressAction
Merge Risk: ⚪ Minimal · up to The full-width context-menu update preserves existing behavior while applying measured widths at the intended mobile call sites. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Since the Expo SDK 57 upgrade (@expo/ui 57.0.15), content wrapped in a native context menu shrinks to its own width. On iOS this left route cards off-center, with a large gap on one side. Favorite route boxes and the fares profile picker were affected too, and the picker on Android as well.
Adds a
fillWidthprop toContextMenuthat gives the content the container's width, and uses it in those three places.