Skip to content

feat(mobile): show no-trains warning in native bottom toolbar on iOS 26+ - #768

Merged
guytepper merged 1 commit into
mainfrom
guytepper/ios-26-bottom-toolbar
Sep 11, 2026
Merged

feat(mobile): show no-trains warning in native bottom toolbar on iOS 26+#768
guytepper merged 1 commit into
mainfrom
guytepper/ios-26-bottom-toolbar

Conversation

@guytepper

Copy link
Copy Markdown
Member

On iOS 26+ the "no trains found for the requested time/date" warning on the route list now renders inside expo-router's native Stack.Toolbar with an orange-tinted Liquid Glass background, replacing the custom orange bottom sheet. Older iOS versions and Android keep the existing sheet and modal. The toolbar host has no intrinsic size, so the custom view gets an explicit width and height. The list's bottom padding was raised so the last route card scrolls clear of the taller toolbar.

Verified on an iOS 27 simulator.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 11, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-11T12:47:44.672020Z c75bf39 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: e4a4aa23-f42c-4a25-9d99-d00bf1ae5db3

📥 Commits

Reviewing files that changed from the base of the PR and between 10d134d and c75bf39.

📒 Files selected for processing (2)
  • apps/mobile/src/screens/route-list/components/route-list-warning.tsx
  • apps/mobile/src/screens/route-list/route-list-screen.tsx

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The route warning now uses a native toolbar with liquid glass on supported iOS versions and retains the bottom sheet fallback. Warning content is shared between both render paths. Route list padding now uses the theme spacing scale.

Changes

Route warning UI

Layer / File(s) Summary
Conditional warning presentation
apps/mobile/src/screens/route-list/components/route-list-warning.tsx
The component detects native toolbar support, extracts shared warning content, and renders either Stack.Toolbar with LiquidGlassView or the existing BottomScreenSheet.
Theme-based warning spacing
apps/mobile/src/screens/route-list/route-list-screen.tsx
Warning-state list padding uses spacing[5] instead of the fixed value 12.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Sequence Diagram(s)

sequenceDiagram
  participant RouteListWarning
  participant StackToolbar
  participant LiquidGlassView
  participant BottomScreenSheet
  RouteListWarning->>RouteListWarning: Check iOS and liquid glass support
  alt Native toolbar supported
    RouteListWarning->>StackToolbar: Render warning content
    StackToolbar->>LiquidGlassView: Render toolbar content
  else Native toolbar unsupported
    RouteListWarning->>BottomScreenSheet: Render warning content
  end
Loading

Merge Risk: ⚪ Minimal · up to c75bf

The warning retains its fallback behavior on unsupported platforms while supported iOS versions receive the native toolbar presentation. No actionable merge risk remains.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the main change: showing the no-trains warning in the native bottom toolbar on iOS 26 and later.
Description check ✅ Passed The description directly explains the native toolbar change, platform-specific fallback behavior, sizing requirement, padding update, and verification.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@guytepper
guytepper merged commit 2b73e04 into main Sep 11, 2026
2 of 4 checks passed
@guytepper
guytepper deleted the guytepper/ios-26-bottom-toolbar branch September 11, 2026 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant