feat(mobile): show no-trains warning in native bottom toolbar on iOS 26+ - #768
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughThe route warning now uses a native toolbar with liquid glass on supported iOS versions and retains the bottom sheet fallback. Warning content is shared between both render paths. Route list padding now uses the theme spacing scale. ChangesRoute warning UI
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant RouteListWarning
participant StackToolbar
participant LiquidGlassView
participant BottomScreenSheet
RouteListWarning->>RouteListWarning: Check iOS and liquid glass support
alt Native toolbar supported
RouteListWarning->>StackToolbar: Render warning content
StackToolbar->>LiquidGlassView: Render toolbar content
else Native toolbar unsupported
RouteListWarning->>BottomScreenSheet: Render warning content
end
Merge Risk: ⚪ Minimal · up to The warning retains its fallback behavior on unsupported platforms while supported iOS versions receive the native toolbar presentation. No actionable merge risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
On iOS 26+ the "no trains found for the requested time/date" warning on the route list now renders inside expo-router's native
Stack.Toolbarwith an orange-tinted Liquid Glass background, replacing the custom orange bottom sheet. Older iOS versions and Android keep the existing sheet and modal. The toolbar host has no intrinsic size, so the custom view gets an explicit width and height. The list's bottom padding was raised so the last route card scrolls clear of the taller toolbar.Verified on an iOS 27 simulator.