Elide lifetime parameters - #7
Merged
Merged
Conversation
BenjaminBrienen
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Elide lifetime parameters from shortened type names.
type_nameincludes lifetime parameters as'_, so a BevyQuerywill have aShortNamelikeQuery<'_, '_, &C>. Instead, we should elide the lifetimes and renderQuery<&C>.Note that
type_namedid not originally include lifetimes, and they were added in rust-lang/rust#145284, after this library was created. So I believe this will restore the original behavior ofShortName::of::<T>().Solution
After a
<character, skip any number of'_,s. If we're left with<'_>, then elide the angle brackets completely.Testing
Added unit tests with lifetimes.