Skip to content

[Chore/#13] EAS 프로젝트 연결 및 앱 기본 정보 정리 - #14

Merged
tnals0924 merged 1 commit into
mainfrom
chore/#13-eas-project-link
Oct 1, 2026
Merged

tnals0924 merged 1 commit into
mainfrom
chore/#13-eas-project-link

Conversation

@tnals0924

@tnals0924 tnals0924 commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

#️⃣연관된 이슈

🎯 해결하려는 문제가 무엇인가요?

앱이 EAS 프로젝트에 연결되어 있지 않아 eas build를 돌릴 수 없었다. README에도 "eas build를 실제로 돌리려면 eas init으로 extra.eas.projectId가 먼저 채워져야 한다"고 적어 두었다.
앱 이름·slug·scheme·스플래시 색도 템플릿 기본값(stream-client-app, streamclientapp, #208AEF)이 그대로 남아 있었다.

❓ 왜 해결해야 하나요?

FCM 푸시 알림을 붙이려면 Expo Go가 아니라 개발 빌드가 필요하고, 개발 빌드를 EAS로 뽑으려면 프로젝트 연결이 먼저 되어 있어야 한다.
홈 화면에 보일 앱 이름, 딥링크 scheme처럼 나중에 바꾸기 번거로운 값은 첫 빌드 전에 정해 두는 편이 낫다.

⭐ 어떻게 해결했나요?

app.json만 바꿨다.

항목 이전 이후
extra.eas.projectId 없음 406e6f5b-… (eas init)
owner 없음 kmusw-stream (Expo 조직)
name stream-client-app 스트림
slug stream-client-app stream (EAS 프로젝트 slug와 맞춤)
version 1.0.0 0.0.1
scheme streamclientapp kmustream
스플래시 backgroundColor #208AEF #FFFFFF

extra.router: {}는 eas init이 설정을 다시 쓰면서 넣은 빈 값이다. 동작에는 영향이 없다.

검증

  • npx expo config --type public으로 위 값이 그대로 읽히는 것 확인
  • pnpm biome check app.json 통과

🧩 이 PR의 한계 & 트레이드오프

  • ios.bundleIdentifier, android.package는 아직 비어 있다. Firebase 앱 등록과 스토어 등록에 쓰이고 스토어에 올린 뒤에는 바꿀 수 없어서, 값을 확정한 뒤 푸시 알림 세팅 작업에서 넣는다
  • README의 eas init 안내 문구는 이번에 고치지 않았다. 개발 빌드 전환 때 로컬 실행 가이드와 함께 고친다

⛓️ 기존 기능에 미치는 영향

  • 코드에서 scheme(streamclientapp)을 참조하는 곳이 없어 딥링크 동작에는 영향이 없다. Expo Go 개발은 exp://로 뜨므로 그대로다
  • 기존 slug로 연결된 EAS 프로젝트가 없었으므로 slug를 바꿔도 잃는 것이 없다
  • eas.json은 appVersionSource: "remote"라 빌드 번호(buildNumber/versionCode)는 EAS가 관리한다. 사용자에게 보이는 버전 문자열은 app.json의 0.0.1을 쓴다
  • 열려 있는 PR #12는 app.json을 건드리지 않아 충돌이 없다

🔀 Edge Case & 실패 시나리오

  • EAS 빌드·eas 명령을 쓰려면 Expo 조직 kmusw-stream의 멤버여야 한다. 멤버가 아니면 권한 오류가 난다

📋 검토한 대안과 선택 이유

  • 없음. eas init이 만든 설정을 그대로 쓴다

💬 리뷰 포인트

  • 앱 이름 스트림, scheme kmustream, 버전 0.0.1이 팀에서 정한 값과 맞는지

Summary by CodeRabbit

  • Updates
    • The app is now named 스트림.
    • The launch screen background is now white.
    • The app’s version and link identifier have been updated.

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 2b5b6915-7450-41c2-ab32-0496e02bfac7

📥 Commits

Reviewing files that changed from the base of the PR and between ad8fa8b and 36d42b3.

📒 Files selected for processing (1)
  • app.json

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The Expo configuration now uses the app name 스트림, slug stream, version 0.0.1, and scheme kmustream. It also sets a white splash-screen background, router configuration, EAS project ID, and Expo owner.

Changes

Expo app configuration

Layer / File(s) Summary
App identity and EAS configuration
app.json
The app name, slug, version, and scheme are updated. The splash-screen background changes to white. The configuration adds an empty router setting, an EAS project ID, and the Expo owner.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 36d42

The requested app identity and EAS settings are present. The available lookup did not verify the project association, but also did not establish a mismatch or a concrete merge-blocking impact.

Architecture Summary

Architecture risk: 🔵 Low · up to 36d42

The change affects 1 system.

Changed systems: app.json

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — app.json (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in app.json: The Expo name, slug, version, and scheme changed to 스트림, stream, 0.0.1, and kmustream; orientation and icon remain unchanged.
  • observed — Modified behavior in app.json: The splash-screen background color changed from #208AEF to #FFFFFF.
  • observed — Modified behavior in app.json: The configuration adds an extra object containing an empty router configuration and EAS project ID 406e6f5b-aa0f-4218-9021-06c59068ccd6, and sets the Expo owner to kmusw-stream.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The diff adds expo.extra.router: {}. Issue #13 requires EAS linkage and the listed app identity and splash values. The empty router setting does not implement one of those requirements, and no relat… Remove extra.router from app.json, or provide a directly linked coding requirement that needs this setting.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main changes: connecting the app to EAS and updating core app information.
Description check ✅ Passed The description covers all required template sections with specific implementation details, validation steps, limitations, impacts, edge cases, alternatives, and review points.
Linked Issues check ✅ Passed PR #14 implements all coding requirements in active issue #13. app.json adds extra.eas.projectId with the EAS project ID and owner kmusw-stream. It sets the app name to 스트림, slug to stream…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Out of Scope Changes check

Explanation

The diff adds expo.extra.router: {}. Issue #13 requires EAS linkage and the listed app identity and splash values. The empty router setting does not implement one of those requirements, and no related router requirement is provided.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@tnals0924
tnals0924 merged commit 2fba89c into main Oct 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EAS 프로젝트 연결 및 앱 기본 정보 정리

1 participant