docs: add maintainers section to CONTRIBUTING.md - #2328
Merged
notmandatory merged 1 commit intoSep 29, 2026
Merged
Conversation
notmandatory
requested review from
evanlinjin and
oleonardolima
as code owners
September 28, 2026 21:37
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2328 +/- ##
=======================================
Coverage 78.84% 78.84%
=======================================
Files 31 31
Lines 6060 6060
Branches 288 288
=======================================
Hits 4778 4778
Misses 1203 1203
Partials 79 79
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
notmandatory
force-pushed
the
docs/update_contributing
branch
from
September 29, 2026 20:38
fcf1e44 to
081e038
Compare
Contributor
|
reACK 081e038 |
1 of 2 tasks
noahjoeris
added a commit
to bitcoindevkit/bdk_wallet
that referenced
this pull request
Sep 30, 2026
284fb1e docs(fix): fix spelling of consensus in CONTRIBUTING.md (Steve Myers) Pull request description: ### Description Small change to fix misspelling of "consensus" in #521. ### Notes to the reviewers I've installed `harper-ls` in my new editor (helix) to catch spelling errors sooner. @noahjoeris caught this typo in bitcoindevkit/bdk#2328. ### Before submitting - [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk_wallet/blob/master/CONTRIBUTING.md) - [ ] This PR breaks the existing API ACKs for top commit: noahjoeris: ACK 284fb1e Tree-SHA512: dc29237356220f75f6b683390195b682edcd933ee9a90278e8a7fd5b5b50876d43e23c77e35bf14d63e465965bcf482f5df16f64b7a05c5ecf8e40e0721680a8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I borrowed from the rust-bitcoin CONTRIBUTING.md file to add a maintainers section to our CONTRIBUTING.md file. The main points I wanted to clarify are:
Notes to the reviewers
These changes match recent bitcoindevkit/bdk_wallet#521 and I'll propose the same change on our other repos.
Changelog notice
Before submitting