docs(electrum): drop stale MSRV section from README - #2330
Open
artofbitcoin wants to merge 2 commits into
Open
artofbitcoin wants to merge 2 commits into
artofbitcoin wants to merge 2 commits into
Conversation
The README still said 1.75.0 and told users to run `cargo update -p home --precise "0.5.9"`, but the crate's rust-version is 1.85.0 since the MSRV bump (8c15308) and `home` is no longer in the dependency tree, so that command fails. Point to ci/pin-msrv.sh like the root README does. The link is absolute so it also works on crates.io. Co-authored-by: Claude <noreply@anthropic.com>
artofbitcoin
requested review from
evanlinjin and
oleonardolima
as code owners
September 29, 2026 17:36
noahjoeris
requested changes
Sep 29, 2026
noahjoeris
left a comment
noahjoeris
left a comment
Contributor
There was a problem hiding this comment.
Thanks for spotting!
I think it's better to drop it than to update it. It's an unnecessary maintenance burden.
artofbitcoin
changed the title
Author
|
Makes sense, thanks @noahjoeris. I dropped the section; the root README already documents the MSRV and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
crates/electrum/README.md(also the crate page on crates.io) still documents the old MSRV:crates/electrum/Cargo.tomlhasrust-version = "1.85.0"since the MSRV bump in 8c15308 (chore(msrv): bump MSRV to1.85.0#2055), which updated the root README but not this file.cargo update -p home --precise "0.5.9", no longer works:homeis not in the dependency tree anymore, so cargo fails witherror: package ID specification 'home' did not match any packages.This updates the MSRV to 1.85.0 and points to
ci/pin-msrv.sh, the same way the root README does.Notes to the reviewers
The link to
pin-msrv.shis absolute on purpose: the README is the crate'sreadmeon crates.io, where a relative../../ci/pin-msrv.shlink would be broken.Changelog notice
None (docs only).
Checklists
All Submissions: