Conversation
Use the current Canonical::balance argument types and settlement predicate while preserving the clock-regression reproduction. On branch fix/issue-2280 Changes to be committed: modified: crates/chain/tests/test_tx_graph.rs
A clock change can give a later eviction an older timestamp than `last_seen`, or leave a later sighting behind a future-dated eviction. Normalize incoming timestamps against the opposing observation, and apply seen/evicted updates chronologically so stored timestamps preserve the observed state across graph round-trips. Stored observation timestamps may differ from caller's clock values.
IjayAbby
changed the title
IjayAbby
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix handling of mempool timestamps when the system clock moves backward. Incoming
seenandevictedobservations are normalized and applied chronologically so transaction state remains correct across graph updates and round-trips.Notes to the reviewers
Changelog notice
Fixed transaction mempool ordering when system clock changes cause non-monotonic timestamps.
Checklists
All Submissions:
Bugfixes: