fix(wallet): check timelocks against the PSBT in finalize_psbt

[Dmenec]

Description

Fixes #580, fixes #557.

finalize_psbt satisfied descriptors with the tuple (PsbtInputSatisfier, After, Older). The satisfiers are treated as an OR, and After and Older only look at the chain height. So a PSBT whose nLockTime or nSequence does not enforce the timelock was still finalized through the after/older branch.

PsbtInputSatisfier already checks nLockTime and nSequence, so this PR drops After and Older from the finalizer. SignOptions::assume_height only fed them, so its no longer used.

Notes to the reviewers

After and Older date back to when the finalizer used psbt::Input as its satisfier, which cannot see the transaction and so could not check timelocks on its own. They stayed in the tuple when it was switched to PsbtInputSatisfier in 100f0aa, and since then they could only turn a false into a true.

This also fixes the panic in #557. It came from Older adding the relative locktime to the u32::MAX height used for unconfirmed inputs, as finalize_psbt no longer goes through Older.

Changelog notice

• Fixed Wallet::finalize_psbt finalizing PSBTs whose nLockTime or nSequence does not enforce the descriptor's timelock.
• SignOptions::assume_height is deprecated

Before submitting

• I've signed all my commits
• I followed the contribution guidelines

Bugfixes

• This PR breaks the existing API
• I've added tests to reproduce the issue ( still have to do tests for finalize_psbt panics with "Overflowing addition" when spending an unconfirmed UTXO of a descriptor with an older() branch #557 )
• I'm linking the issue being fixed by this PR

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.44%. Comparing base (e46e668) to head (2c5c01a).

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #582      +/-   ##
==========================================
- Coverage   81.66%   81.44%   -0.23%     
==========================================
  Files          25       25              
  Lines        6339     6295      -44     
  Branches      302      301       -1     
==========================================
- Hits         5177     5127      -50     
- Misses       1055     1061       +6     
  Partials      107      107              

Flag	Coverage Δ
rust	81.44% <100.00%> (-0.23%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.