Skip to content

stewards: exclude teammate PRs from the gate-met stuck check (BB-382) - #426

Merged
trotterdylan merged 1 commit into
mainfrom
bb/bb-382-exclude-teammate-prs-from-gate-met-stuck-thr_wgc2ksbkrb
Nov 21, 2026
Merged

trotterdylan merged 1 commit into
mainfrom
bb/bb-382-exclude-teammate-prs-from-gate-met-stuck-thr_wgc2ksbkrb

Conversation

@trotterdylan

Copy link
Copy Markdown
Collaborator

Implements BB-382. The BB-285 gate-met stuck detector fired on every approved, gate-met teammate pull request once it sat past the window, although "waiting on the author to merge" is the intended state (BB-170). The check now skips a teammate's pull request (foreignOwner). A playbook's owner-merges: true turns foreignOwner off, so those keep their Merge item.

Any merge to bb-plugins main, docs included, moves the pin, builds a new bb-server image and stages a restart on every developer's server.

Sibling PR: none.

Classification

owner-reviewed: removes existing behaviour (the gate-met stuck escalation) for teammate pull requests. plugins/stewards/server.ts is project-decided per bigDecisions ("The stewards plugin outside its authority seams"), so the project steward approves.

What changes

  • plugins/stewards/server.ts. The BB-285 gate-met stuck condition adds !foreignOwner: a teammate's approved pull request (a review binding, or a pr binding whose author is not the owner, that is not a dependency bot and does not set owner-merges) raises no stuck escalation and no "gate-met with nobody acting" note. Its pull-foreign-owner decline, the "waiting on the author to merge" hold, is unchanged. An owner's own agent PR, a dependency-bot PR, and a teammate PR under owner-merges: true are not foreignOwner and keep the check.
  • plugins/stewards/server.test.ts. The two existing BB-285 tests that used a teammate review binding to reach the stuck were moved onto an owner's own agent pull request (a refused merge leaves the plugin neither merging nor filing a need, so nobody is acting). New tests cover the teammate exclusion and the non-foreignOwner cases.

Note on owner-merges. A teammate's pull request under owner-merges: true files the owner's Merge item (its current behaviour) and so is never unattended; the test asserts that flag and that it is not declined as a foreign owner. The gate-met stuck is not the mechanism for it.

Testing

  • npm run typecheck: pass.
  • npx vitest run in plugins/stewards (the changed plugin's full suite, run beyond CI's matrix per .bb/AGENTS.md "Testing"): pass — 55 files, 2297 tests.
  • The teammate test was run against the unfixed condition and fails there (the stuck is raised).

@trotterdylan

Copy link
Copy Markdown
Collaborator Author

Independent review running in bb thread @thread:thr_sfbmnrurbv.

— from bb thread thr_wgc2ksbkrb

@trotterdylan

Copy link
Copy Markdown
Collaborator Author

Review round 1 (Claude Opus 5.5, at 5ee709d)

Owner review required: yes — it changes what an existing feature does (the BB-285 gate-met stuck no longer fires for teammate PRs). The decide list entry "The stewards plugin outside its authority seams" is decide: project, so the project steward approves. The merge and spec gate inputs are untouched.

Tested

  • Ran: stewards npm run typecheck and npm test (pass, 2297 tests; stewards is still in progress in CI). With !foreignOwner reverted, the new teammate test fails and the rest of the BB-285 block passes.

Looks good.

— from bb thread thr_sfbmnrurbv

@trotterdylan

Copy link
Copy Markdown
Collaborator Author

Approved as "The stewards plugin outside its authority seams (the app and sidebar UI, its skills, every other stewards file); forwarded to the user when it alters what the merge or spec gate reads (signatures, snapshot viewer or author, product inputs, the user's spec comments)".

— from bb thread thr_rkn6gtwp8m

@trotterdylan
trotterdylan merged commit aa7709c into main Nov 21, 2026
25 checks passed
@trotterdylan

Copy link
Copy Markdown
Collaborator Author

Merged: owner-reviewed lane, reviewer approved 5ee709d, checks green, approved by the project steward.
merge commit aa7709c
Note: merging this moves the pin and stages a restart for every developer's server (Restart now, or in the 03:00–05:00 ET quiet window).
dispatched bb-server.yaml on bitcomplete/bb-gate@main

@trotterdylan
trotterdylan deleted the bb/bb-382-exclude-teammate-prs-from-gate-met-stuck-thr_wgc2ksbkrb branch November 21, 2026 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant