Repository navigation
stewards: exclude teammate PRs from the gate-met stuck check (BB-382) - #426
Conversation
|
Independent review running in bb thread @thread:thr_sfbmnrurbv. — from bb thread thr_wgc2ksbkrb |
Review round 1 (Claude Opus 5.5, at 5ee709d)Owner review required: yes — it changes what an existing feature does (the BB-285 gate-met stuck no longer fires for teammate PRs). The decide list entry "The stewards plugin outside its authority seams" is decide: project, so the project steward approves. The merge and spec gate inputs are untouched. Tested
Looks good. — from bb thread thr_sfbmnrurbv |
|
Approved as "The stewards plugin outside its authority seams (the app and sidebar UI, its skills, every other stewards file); forwarded to the user when it alters what the merge or spec gate reads (signatures, snapshot viewer or author, product inputs, the user's spec comments)". — from bb thread thr_rkn6gtwp8m |
|
Merged: owner-reviewed lane, reviewer approved 5ee709d, checks green, approved by the project steward. |
Implements BB-382. The BB-285 gate-met stuck detector fired on every approved, gate-met teammate pull request once it sat past the window, although "waiting on the author to merge" is the intended state (BB-170). The check now skips a teammate's pull request (
foreignOwner). A playbook'sowner-merges: trueturnsforeignOwneroff, so those keep their Merge item.Sibling PR: none.
Classification
owner-reviewed: removes existing behaviour (the gate-met stuck escalation) for teammate pull requests.
plugins/stewards/server.tsis project-decided perbigDecisions("The stewards plugin outside its authority seams"), so the project steward approves.What changes
plugins/stewards/server.ts. The BB-285 gate-met stuck condition adds!foreignOwner: a teammate's approved pull request (a review binding, or aprbinding whose author is not the owner, that is not a dependency bot and does not setowner-merges) raises nostuckescalation and no "gate-met with nobody acting" note. Itspull-foreign-ownerdecline, the "waiting on the author to merge" hold, is unchanged. An owner's own agent PR, a dependency-bot PR, and a teammate PR underowner-merges: trueare notforeignOwnerand keep the check.plugins/stewards/server.test.ts. The two existing BB-285 tests that used a teammate review binding to reach the stuck were moved onto an owner's own agent pull request (a refused merge leaves the plugin neither merging nor filing a need, so nobody is acting). New tests cover the teammate exclusion and the non-foreignOwner cases.Note on
owner-merges. A teammate's pull request underowner-merges: truefiles the owner's Merge item (its current behaviour) and so is never unattended; the test asserts that flag and that it is not declined as a foreign owner. The gate-met stuck is not the mechanism for it.Testing
npm run typecheck: pass.npx vitest runinplugins/stewards(the changed plugin's full suite, run beyond CI's matrix per.bb/AGENTS.md"Testing"): pass — 55 files, 2297 tests.